Compare commits

..

17 commits
1.1.7 ... main

Author SHA1 Message Date
b7e3418f0f
remove deprecated rectors
All checks were successful
/ ls (push) Successful in 28s
2024-08-18 09:17:23 +02:00
e40beaa2d1
bump-dependencies
All checks were successful
/ ls (push) Successful in 29s
2024-08-18 09:09:16 +02:00
2793c36fa9 Merge pull request 'add_ClassAttributeSeparationFixer' (#3) from add_ClassAttributeSeparationFixer into main
All checks were successful
/ ls (push) Successful in 13s
Reviewed-on: #3
2024-05-04 18:26:43 +00:00
e7ecf55e04
ci-fix
All checks were successful
/ ls (push) Successful in 12s
2024-05-04 20:24:57 +02:00
Continuous Integration
00f72e3be9 Continuous Integration Fixes 2024-05-04 17:42:09 +00:00
9993d760d6
add ClassAttributeSeparationFixer
All checks were successful
/ ls (push) Successful in 17s
2024-05-04 19:41:48 +02:00
b1792809e1 Merge pull request 'add workflow' (#2) from add_actions into main
All checks were successful
/ ls (push) Successful in 16s
Reviewed-on: #2
2024-05-04 17:34:39 +00:00
713b047068
add workflow
All checks were successful
/ ls (push) Successful in 16s
2024-05-04 19:33:42 +02:00
d668217619 temporary skip linelengthfixer 2024-04-25 21:01:06 +02:00
cfd59433a4 bump dependencies 2024-04-25 18:07:52 +02:00
894d6ec850 clean up rector config 2024-02-03 10:58:53 +01:00
8c90c27762 bump versions and set php83 as new target 2024-02-03 01:07:15 +01:00
f30fbd3758 bump dependencies and update config 2024-01-25 18:31:04 +01:00
3c81249b90 update rules 2023-11-29 18:27:33 +01:00
3c9679da8e bump dependencies 2023-11-29 17:14:42 +01:00
lubiana
5d731e63f9
update rector rules. bump versions 2023-09-01 07:52:22 +02:00
lubiana
a83530af35
bump versions 2023-05-29 20:30:17 +02:00
9 changed files with 237 additions and 198 deletions

View file

@ -0,0 +1,34 @@
on: [push]
jobs:
ls:
runs-on: docker
container:
image: git.php.fail/lubiana/container/php:ci
steps:
- name: Manually checkout
env:
REPO: '${{ github.repository }}'
TOKEN: '${{ secrets.GITHUB_TOKEN }}'
GIT_SERVER: 'git.php.fail'
run: |
git clone --branch $GITHUB_REF_NAME https://${TOKEN}@${GIT_SERVER}/${REPO}.git .
git fetch
git checkout ${{ github.head_ref }}
- name: composer install
env:
COMPOSER_CACHE_DIR: /opt/hostedtoolcache/.composer/cache/files
run: |
mkdir -p ${{ env.COMPOSER_CACHE_DIR }}
composer install
- run: composer lint
- name: GIT commit and push all changed files
env:
CI_COMMIT_MESSAGE: Continuous Integration Fixes
CI_COMMIT_AUTHOR: Continuous Integration
run: |
if [[ -n "$(git status -s)" ]]; then
git config --global user.name "${{ env.CI_COMMIT_AUTHOR }}"
git config --global user.email "gitbot@users.noreply.php.fail"
git commit -am "${{ env.CI_COMMIT_MESSAGE }}"
git push
fi

View file

@ -8,13 +8,21 @@
} }
}, },
"require": { "require": {
"slevomat/coding-standard": "^8.9", "php": "^8.3",
"symplify/easy-coding-standard": "^11.3.2", "slevomat/coding-standard": "^8.15",
"rector/rector": "^0.15.23" "symplify/easy-coding-standard": "^12.3.5",
"rector/rector": "^1.0.5"
}, },
"config": { "config": {
"allow-plugins": { "allow-plugins": {
"dealerdirect/phpcodesniffer-composer-installer": true "dealerdirect/phpcodesniffer-composer-installer": true
} }
},
"scripts": {
"lint": [
"rector",
"ecs --fix",
"ecs --fix"
]
} }
} }

156
composer.lock generated
View file

@ -4,7 +4,7 @@
"Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies", "Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies",
"This file is @generated automatically" "This file is @generated automatically"
], ],
"content-hash": "959b2ea13afa4a341c7d2ad2cf7c38f8", "content-hash": "6eb7806e6594ecc073d158d2f9b483f0",
"packages": [ "packages": [
{ {
"name": "dealerdirect/phpcodesniffer-composer-installer", "name": "dealerdirect/phpcodesniffer-composer-installer",
@ -86,22 +86,24 @@
}, },
{ {
"name": "phpstan/phpdoc-parser", "name": "phpstan/phpdoc-parser",
"version": "1.16.1", "version": "1.28.0",
"source": { "source": {
"type": "git", "type": "git",
"url": "https://github.com/phpstan/phpdoc-parser.git", "url": "https://github.com/phpstan/phpdoc-parser.git",
"reference": "e27e92d939e2e3636f0a1f0afaba59692c0bf571" "reference": "cd06d6b1a1b3c75b0b83f97577869fd85a3cd4fb"
}, },
"dist": { "dist": {
"type": "zip", "type": "zip",
"url": "https://api.github.com/repos/phpstan/phpdoc-parser/zipball/e27e92d939e2e3636f0a1f0afaba59692c0bf571", "url": "https://api.github.com/repos/phpstan/phpdoc-parser/zipball/cd06d6b1a1b3c75b0b83f97577869fd85a3cd4fb",
"reference": "e27e92d939e2e3636f0a1f0afaba59692c0bf571", "reference": "cd06d6b1a1b3c75b0b83f97577869fd85a3cd4fb",
"shasum": "" "shasum": ""
}, },
"require": { "require": {
"php": "^7.2 || ^8.0" "php": "^7.2 || ^8.0"
}, },
"require-dev": { "require-dev": {
"doctrine/annotations": "^2.0",
"nikic/php-parser": "^4.15",
"php-parallel-lint/php-parallel-lint": "^1.2", "php-parallel-lint/php-parallel-lint": "^1.2",
"phpstan/extension-installer": "^1.0", "phpstan/extension-installer": "^1.0",
"phpstan/phpstan": "^1.5", "phpstan/phpstan": "^1.5",
@ -125,22 +127,22 @@
"description": "PHPDoc parser with support for nullable, intersection and generic types", "description": "PHPDoc parser with support for nullable, intersection and generic types",
"support": { "support": {
"issues": "https://github.com/phpstan/phpdoc-parser/issues", "issues": "https://github.com/phpstan/phpdoc-parser/issues",
"source": "https://github.com/phpstan/phpdoc-parser/tree/1.16.1" "source": "https://github.com/phpstan/phpdoc-parser/tree/1.28.0"
}, },
"time": "2023-02-07T18:11:17+00:00" "time": "2024-04-03T18:51:33+00:00"
}, },
{ {
"name": "phpstan/phpstan", "name": "phpstan/phpstan",
"version": "1.10.8", "version": "1.10.67",
"source": { "source": {
"type": "git", "type": "git",
"url": "https://github.com/phpstan/phpstan.git", "url": "https://github.com/phpstan/phpstan.git",
"reference": "0166aef76e066f0dd2adc2799bdadfa1635711e9" "reference": "16ddbe776f10da6a95ebd25de7c1dbed397dc493"
}, },
"dist": { "dist": {
"type": "zip", "type": "zip",
"url": "https://api.github.com/repos/phpstan/phpstan/zipball/0166aef76e066f0dd2adc2799bdadfa1635711e9", "url": "https://api.github.com/repos/phpstan/phpstan/zipball/16ddbe776f10da6a95ebd25de7c1dbed397dc493",
"reference": "0166aef76e066f0dd2adc2799bdadfa1635711e9", "reference": "16ddbe776f10da6a95ebd25de7c1dbed397dc493",
"shasum": "" "shasum": ""
}, },
"require": { "require": {
@ -183,31 +185,27 @@
{ {
"url": "https://github.com/phpstan", "url": "https://github.com/phpstan",
"type": "github" "type": "github"
},
{
"url": "https://tidelift.com/funding/github/packagist/phpstan/phpstan",
"type": "tidelift"
} }
], ],
"time": "2023-03-24T10:28:16+00:00" "time": "2024-04-16T07:22:02+00:00"
}, },
{ {
"name": "rector/rector", "name": "rector/rector",
"version": "0.15.23", "version": "1.0.5",
"source": { "source": {
"type": "git", "type": "git",
"url": "https://github.com/rectorphp/rector.git", "url": "https://github.com/rectorphp/rector.git",
"reference": "f4984ebd62b3613002869b0ddd6868261d62819e" "reference": "73eb63e4f9011dba6b7c66c3262543014e352f34"
}, },
"dist": { "dist": {
"type": "zip", "type": "zip",
"url": "https://api.github.com/repos/rectorphp/rector/zipball/f4984ebd62b3613002869b0ddd6868261d62819e", "url": "https://api.github.com/repos/rectorphp/rector/zipball/73eb63e4f9011dba6b7c66c3262543014e352f34",
"reference": "f4984ebd62b3613002869b0ddd6868261d62819e", "reference": "73eb63e4f9011dba6b7c66c3262543014e352f34",
"shasum": "" "shasum": ""
}, },
"require": { "require": {
"php": "^7.2|^8.0", "php": "^7.2|^8.0",
"phpstan/phpstan": "^1.10.1" "phpstan/phpstan": "^1.10.57"
}, },
"conflict": { "conflict": {
"rector/rector-doctrine": "*", "rector/rector-doctrine": "*",
@ -215,15 +213,13 @@
"rector/rector-phpunit": "*", "rector/rector-phpunit": "*",
"rector/rector-symfony": "*" "rector/rector-symfony": "*"
}, },
"suggest": {
"ext-dom": "To manipulate phpunit.xml via the custom-rule command"
},
"bin": [ "bin": [
"bin/rector" "bin/rector"
], ],
"type": "library", "type": "library",
"extra": {
"branch-alias": {
"dev-main": "0.15-dev"
}
},
"autoload": { "autoload": {
"files": [ "files": [
"bootstrap.php" "bootstrap.php"
@ -242,7 +238,7 @@
], ],
"support": { "support": {
"issues": "https://github.com/rectorphp/rector/issues", "issues": "https://github.com/rectorphp/rector/issues",
"source": "https://github.com/rectorphp/rector/tree/0.15.23" "source": "https://github.com/rectorphp/rector/tree/1.0.5"
}, },
"funding": [ "funding": [
{ {
@ -250,36 +246,36 @@
"type": "github" "type": "github"
} }
], ],
"time": "2023-03-22T15:22:45+00:00" "time": "2024-05-10T05:31:15+00:00"
}, },
{ {
"name": "slevomat/coding-standard", "name": "slevomat/coding-standard",
"version": "8.9.0", "version": "8.15.0",
"source": { "source": {
"type": "git", "type": "git",
"url": "https://github.com/slevomat/coding-standard.git", "url": "https://github.com/slevomat/coding-standard.git",
"reference": "8f11e0f5ff984d6862bb9d83aa513dc05a1773ef" "reference": "7d1d957421618a3803b593ec31ace470177d7817"
}, },
"dist": { "dist": {
"type": "zip", "type": "zip",
"url": "https://api.github.com/repos/slevomat/coding-standard/zipball/8f11e0f5ff984d6862bb9d83aa513dc05a1773ef", "url": "https://api.github.com/repos/slevomat/coding-standard/zipball/7d1d957421618a3803b593ec31ace470177d7817",
"reference": "8f11e0f5ff984d6862bb9d83aa513dc05a1773ef", "reference": "7d1d957421618a3803b593ec31ace470177d7817",
"shasum": "" "shasum": ""
}, },
"require": { "require": {
"dealerdirect/phpcodesniffer-composer-installer": "^0.6.2 || ^0.7 || ^1.0", "dealerdirect/phpcodesniffer-composer-installer": "^0.6.2 || ^0.7 || ^1.0",
"php": "^7.2 || ^8.0", "php": "^7.2 || ^8.0",
"phpstan/phpdoc-parser": ">=1.16.0 <1.17.0", "phpstan/phpdoc-parser": "^1.23.1",
"squizlabs/php_codesniffer": "^3.7.1" "squizlabs/php_codesniffer": "^3.9.0"
}, },
"require-dev": { "require-dev": {
"phing/phing": "2.17.4", "phing/phing": "2.17.4",
"php-parallel-lint/php-parallel-lint": "1.3.2", "php-parallel-lint/php-parallel-lint": "1.3.2",
"phpstan/phpstan": "1.4.10|1.10.8", "phpstan/phpstan": "1.10.60",
"phpstan/phpstan-deprecation-rules": "1.1.3", "phpstan/phpstan-deprecation-rules": "1.1.4",
"phpstan/phpstan-phpunit": "1.0.0|1.3.10", "phpstan/phpstan-phpunit": "1.3.16",
"phpstan/phpstan-strict-rules": "1.5.0", "phpstan/phpstan-strict-rules": "1.5.2",
"phpunit/phpunit": "7.5.20|8.5.21|9.6.5" "phpunit/phpunit": "8.5.21|9.6.8|10.5.11"
}, },
"type": "phpcodesniffer-standard", "type": "phpcodesniffer-standard",
"extra": { "extra": {
@ -303,7 +299,7 @@
], ],
"support": { "support": {
"issues": "https://github.com/slevomat/coding-standard/issues", "issues": "https://github.com/slevomat/coding-standard/issues",
"source": "https://github.com/slevomat/coding-standard/tree/8.9.0" "source": "https://github.com/slevomat/coding-standard/tree/8.15.0"
}, },
"funding": [ "funding": [
{ {
@ -315,20 +311,20 @@
"type": "tidelift" "type": "tidelift"
} }
], ],
"time": "2023-03-25T15:52:37+00:00" "time": "2024-03-09T15:20:58+00:00"
}, },
{ {
"name": "squizlabs/php_codesniffer", "name": "squizlabs/php_codesniffer",
"version": "3.7.2", "version": "3.9.2",
"source": { "source": {
"type": "git", "type": "git",
"url": "https://github.com/squizlabs/PHP_CodeSniffer.git", "url": "https://github.com/PHPCSStandards/PHP_CodeSniffer.git",
"reference": "ed8e00df0a83aa96acf703f8c2979ff33341f879" "reference": "aac1f6f347a5c5ac6bc98ad395007df00990f480"
}, },
"dist": { "dist": {
"type": "zip", "type": "zip",
"url": "https://api.github.com/repos/squizlabs/PHP_CodeSniffer/zipball/ed8e00df0a83aa96acf703f8c2979ff33341f879", "url": "https://api.github.com/repos/PHPCSStandards/PHP_CodeSniffer/zipball/aac1f6f347a5c5ac6bc98ad395007df00990f480",
"reference": "ed8e00df0a83aa96acf703f8c2979ff33341f879", "reference": "aac1f6f347a5c5ac6bc98ad395007df00990f480",
"shasum": "" "shasum": ""
}, },
"require": { "require": {
@ -338,11 +334,11 @@
"php": ">=5.4.0" "php": ">=5.4.0"
}, },
"require-dev": { "require-dev": {
"phpunit/phpunit": "^4.0 || ^5.0 || ^6.0 || ^7.0" "phpunit/phpunit": "^4.0 || ^5.0 || ^6.0 || ^7.0 || ^8.0 || ^9.3.4"
}, },
"bin": [ "bin": [
"bin/phpcs", "bin/phpcbf",
"bin/phpcbf" "bin/phpcs"
], ],
"type": "library", "type": "library",
"extra": { "extra": {
@ -357,44 +353,70 @@
"authors": [ "authors": [
{ {
"name": "Greg Sherwood", "name": "Greg Sherwood",
"role": "lead" "role": "Former lead"
},
{
"name": "Juliette Reinders Folmer",
"role": "Current lead"
},
{
"name": "Contributors",
"homepage": "https://github.com/PHPCSStandards/PHP_CodeSniffer/graphs/contributors"
} }
], ],
"description": "PHP_CodeSniffer tokenizes PHP, JavaScript and CSS files and detects violations of a defined set of coding standards.", "description": "PHP_CodeSniffer tokenizes PHP, JavaScript and CSS files and detects violations of a defined set of coding standards.",
"homepage": "https://github.com/squizlabs/PHP_CodeSniffer", "homepage": "https://github.com/PHPCSStandards/PHP_CodeSniffer",
"keywords": [ "keywords": [
"phpcs", "phpcs",
"standards", "standards",
"static analysis" "static analysis"
], ],
"support": { "support": {
"issues": "https://github.com/squizlabs/PHP_CodeSniffer/issues", "issues": "https://github.com/PHPCSStandards/PHP_CodeSniffer/issues",
"source": "https://github.com/squizlabs/PHP_CodeSniffer", "security": "https://github.com/PHPCSStandards/PHP_CodeSniffer/security/policy",
"wiki": "https://github.com/squizlabs/PHP_CodeSniffer/wiki" "source": "https://github.com/PHPCSStandards/PHP_CodeSniffer",
"wiki": "https://github.com/PHPCSStandards/PHP_CodeSniffer/wiki"
}, },
"time": "2023-02-22T23:07:41+00:00" "funding": [
{
"url": "https://github.com/PHPCSStandards",
"type": "github"
},
{
"url": "https://github.com/jrfnl",
"type": "github"
},
{
"url": "https://opencollective.com/php_codesniffer",
"type": "open_collective"
}
],
"time": "2024-04-23T20:25:34+00:00"
}, },
{ {
"name": "symplify/easy-coding-standard", "name": "symplify/easy-coding-standard",
"version": "11.3.2", "version": "12.3.5",
"source": { "source": {
"type": "git", "type": "git",
"url": "https://github.com/easy-coding-standard/easy-coding-standard.git", "url": "https://github.com/easy-coding-standard/easy-coding-standard.git",
"reference": "d4159e06c0970e71a2a58d350160241e7cb3994b" "reference": "0d7c2cfee3debdf11c12135e90d69d1d9f4eef03"
}, },
"dist": { "dist": {
"type": "zip", "type": "zip",
"url": "https://api.github.com/repos/easy-coding-standard/easy-coding-standard/zipball/d4159e06c0970e71a2a58d350160241e7cb3994b", "url": "https://api.github.com/repos/easy-coding-standard/easy-coding-standard/zipball/0d7c2cfee3debdf11c12135e90d69d1d9f4eef03",
"reference": "d4159e06c0970e71a2a58d350160241e7cb3994b", "reference": "0d7c2cfee3debdf11c12135e90d69d1d9f4eef03",
"shasum": "" "shasum": ""
}, },
"require": { "require": {
"php": ">=7.2" "php": ">=7.2"
}, },
"conflict": { "conflict": {
"friendsofphp/php-cs-fixer": "<3.0", "friendsofphp/php-cs-fixer": "<3.46",
"squizlabs/php_codesniffer": "<3.6", "phpcsstandards/php_codesniffer": "<3.8",
"symplify/coding-standard": "<11.3" "symplify/coding-standard": "<12.1"
},
"suggest": {
"ext-dom": "Needed to support checkstyle output format in class CheckstyleOutputFormatter"
}, },
"bin": [ "bin": [
"bin/ecs" "bin/ecs"
@ -418,7 +440,7 @@
], ],
"support": { "support": {
"issues": "https://github.com/easy-coding-standard/easy-coding-standard/issues", "issues": "https://github.com/easy-coding-standard/easy-coding-standard/issues",
"source": "https://github.com/easy-coding-standard/easy-coding-standard/tree/11.3.2" "source": "https://github.com/easy-coding-standard/easy-coding-standard/tree/12.3.5"
}, },
"funding": [ "funding": [
{ {
@ -430,7 +452,7 @@
"type": "github" "type": "github"
} }
], ],
"time": "2023-03-22T15:28:51+00:00" "time": "2024-08-08T08:43:50+00:00"
} }
], ],
"packages-dev": [], "packages-dev": [],
@ -439,7 +461,9 @@
"stability-flags": [], "stability-flags": [],
"prefer-stable": false, "prefer-stable": false,
"prefer-lowest": false, "prefer-lowest": false,
"platform": [], "platform": {
"php": "^8.3"
},
"platform-dev": [], "platform-dev": [],
"plugin-api-version": "2.3.0" "plugin-api-version": "2.6.0"
} }

View file

@ -1,8 +1,11 @@
<?php declare(strict_types=1); <?php declare(strict_types=1);
use PhpCsFixer\Fixer\Basic\BracesFixer; use PhpCsFixer\Fixer\ClassNotation\ClassAttributesSeparationFixer;
use PhpCsFixer\Fixer\Import\OrderedImportsFixer; use PhpCsFixer\Fixer\Import\OrderedImportsFixer;
use PhpCsFixer\Fixer\LanguageConstruct\FunctionToConstantFixer;
use PhpCsFixer\Fixer\Operator\NewWithBracesFixer; use PhpCsFixer\Fixer\Operator\NewWithBracesFixer;
use PhpCsFixer\Fixer\Operator\NewWithParenthesesFixer;
use PhpCsFixer\Fixer\Operator\OperatorLinebreakFixer;
use PhpCsFixer\Fixer\PhpTag\BlankLineAfterOpeningTagFixer; use PhpCsFixer\Fixer\PhpTag\BlankLineAfterOpeningTagFixer;
use PhpCsFixer\Fixer\Whitespace\NoExtraBlankLinesFixer; use PhpCsFixer\Fixer\Whitespace\NoExtraBlankLinesFixer;
use PhpCsFixer\Fixer\Whitespace\NoWhitespaceInBlankLineFixer; use PhpCsFixer\Fixer\Whitespace\NoWhitespaceInBlankLineFixer;
@ -19,44 +22,38 @@ use SlevomatCodingStandard\Sniffs\TypeHints\DeclareStrictTypesSniff;
use SlevomatCodingStandard\Sniffs\TypeHints\UnionTypeHintFormatSniff; use SlevomatCodingStandard\Sniffs\TypeHints\UnionTypeHintFormatSniff;
use Symplify\CodingStandard\Fixer\LineLength\LineLengthFixer; use Symplify\CodingStandard\Fixer\LineLength\LineLengthFixer;
use Symplify\EasyCodingStandard\Config\ECSConfig; use Symplify\EasyCodingStandard\Config\ECSConfig;
use Symplify\EasyCodingStandard\ValueObject\Set\SetList;
return static function (ECSConfig $c): void { return ECSConfig::configure()
$c->skip([ ->withPreparedSets(
BlankLineAfterOpeningTagFixer::class, symplify: true,
NewWithBracesFixer::class, arrays: true,
OrderedImportsFixer::class, comments: true,
]); docblocks: true,
spaces: true,
$c->sets([ namespaces: true,
SetList::ARRAY, controlStructures: true,
SetList::CLEAN_CODE, strict: true,
SetList::COMMENTS, cleanCode: true
SetList::COMMON, )
SetList::CONTROL_STRUCTURES, ->withPhpCsFixerSets(
SetList::DOCBLOCK, perCS: true,
SetList::NAMESPACES, perCSRisky: true,
SetList::PSR_12, php80MigrationRisky: true,
SetList::SPACES, php83Migration: true,
SetList::STRICT, )
SetList::SYMPLIFY, ->withRules([
]);
// force visibility declaration on class constants
$c->ruleWithConfiguration(ClassConstantVisibilitySniff::class, [
'fixable' => true,
]);
// sort all use statements
$c->rules([
AlphabeticallySortedUsesSniff::class, AlphabeticallySortedUsesSniff::class,
DisallowGroupUseSniff::class, DisallowGroupUseSniff::class,
MultipleUsesPerLineSniff::class, MultipleUsesPerLineSniff::class,
NamespaceSpacingSniff::class, NamespaceSpacingSniff::class,
]); OperatorLinebreakFixer::class,
NoWhitespaceInBlankLineFixer::class,
// import all namespaces, and event php core functions and classes NewWithoutParenthesesSniff::class,
$c->ruleWithConfiguration( ])
->withConfiguredRule(ClassConstantVisibilitySniff::class, [
'fixable' => true,
])
->withConfiguredRule(
ReferenceUsedNamesOnlySniff::class, ReferenceUsedNamesOnlySniff::class,
[ [
'allowFallbackGlobalConstants' => false, 'allowFallbackGlobalConstants' => false,
@ -69,51 +66,57 @@ return static function (ECSConfig $c): void {
'allowFullyQualifiedNameForCollidingFunctions' => true, 'allowFullyQualifiedNameForCollidingFunctions' => true,
'searchAnnotations' => true, 'searchAnnotations' => true,
] ]
); )
// define newlines between use statements // define newlines between use statements
$c->ruleWithConfiguration(UseSpacingSniff::class, [ ->withConfiguredRule(
UseSpacingSniff::class,
[
'linesCountAfterLastUse' => 1, 'linesCountAfterLastUse' => 1,
'linesCountBeforeFirstUse' => 1, 'linesCountBeforeFirstUse' => 1,
'linesCountBetweenUseTypes' => 1, 'linesCountBetweenUseTypes' => 1,
]); ]
)
// strict types declaration should be on same line as opening tag ->withConfiguredRule(
$c->ruleWithConfiguration( ClassAttributesSeparationFixer::class,
[
'elements' => [
'const' => 'none',
'method' => 'one',
'property' => 'none',
'trait_import' => 'none',
'case' => 'none',
],
],
)->withConfiguredRule(
DeclareStrictTypesSniff::class, DeclareStrictTypesSniff::class,
[ [
'declareOnFirstLine' => true, 'declareOnFirstLine' => true,
'spacesCountAroundEqualsSign' => 0, 'spacesCountAroundEqualsSign' => 0,
] ]
); )
->withConfiguredRule(
// disallow ?Foo typehint in favor of Foo|null UnionTypeHintFormatSniff::class,
$c->ruleWithConfiguration(UnionTypeHintFormatSniff::class, [ [
'nullPosition' => 'last', 'nullPosition' => 'last',
'shortNullable' => 'no', 'shortNullable' => 'no',
'withSpaces' => 'no', 'withSpaces' => 'no',
]); ]
)
// Remove useless parentheses in new statements ->withConfiguredRule(
$c->rule(BracesFixer::class);
$c->rule(NewWithoutParenthesesSniff::class);
// do not inline short multilinestatements
$c->ruleWithConfiguration(LineLengthFixer::class, [
LineLengthFixer::INLINE_SHORT_LINES => false,
]);
$c->ruleWithConfiguration(
NoExtraBlankLinesFixer::class, NoExtraBlankLinesFixer::class,
[ [
'tokens' => ['square_brace_block', 'return', 'extra'], 'tokens' => ['square_brace_block', 'return', 'extra'],
] ]
); )
->withConfiguredRule(AttributeAndTargetSpacingSniff::class, [
$c->rule(NoWhitespaceInBlankLineFixer::class);
// make sure that the attribute target is on the line after the attribute
$c->ruleWithConfiguration(AttributeAndTargetSpacingSniff::class, [
'linesCount' => 0, 'linesCount' => 0,
])
->withSkip([
BlankLineAfterOpeningTagFixer::class,
OrderedImportsFixer::class,
FunctionToConstantFixer::class,
NewWithParenthesesFixer::class,
NewWithBracesFixer::class,
LineLengthFixer::class,
]); ]);
};

View file

@ -14,19 +14,15 @@ use Rector\CodingStyle\Rector\ClassMethod\NewlineBeforeNewAssignSetRector;
use Rector\CodingStyle\Rector\Closure\StaticClosureRector; use Rector\CodingStyle\Rector\Closure\StaticClosureRector;
use Rector\CodingStyle\Rector\FuncCall\CountArrayToEmptyArrayComparisonRector; use Rector\CodingStyle\Rector\FuncCall\CountArrayToEmptyArrayComparisonRector;
use Rector\CodingStyle\Rector\If_\NullableCompareToNullRector; use Rector\CodingStyle\Rector\If_\NullableCompareToNullRector;
use Rector\CodingStyle\Rector\Stmt\NewlineAfterStatementRector;
use Rector\Config\RectorConfig; use Rector\Config\RectorConfig;
use Rector\EarlyReturn\Rector\Foreach_\ChangeNestedForeachIfsToEarlyContinueRector; use Rector\EarlyReturn\Rector\Foreach_\ChangeNestedForeachIfsToEarlyContinueRector;
use Rector\EarlyReturn\Rector\If_\ChangeAndIfToEarlyReturnRector;
use Rector\EarlyReturn\Rector\If_\ChangeNestedIfsToEarlyReturnRector; use Rector\EarlyReturn\Rector\If_\ChangeNestedIfsToEarlyReturnRector;
use Rector\EarlyReturn\Rector\If_\ChangeOrIfContinueToMultiContinueRector; use Rector\EarlyReturn\Rector\If_\ChangeOrIfContinueToMultiContinueRector;
use Rector\EarlyReturn\Rector\If_\ChangeOrIfReturnToEarlyReturnRector; use Rector\EarlyReturn\Rector\If_\RemoveAlwaysElseRector;
use Rector\EarlyReturn\Rector\Return_\PreparedValueToEarlyReturnRector; use Rector\EarlyReturn\Rector\Return_\PreparedValueToEarlyReturnRector;
use Rector\EarlyReturn\Rector\Return_\ReturnBinaryAndToEarlyReturnRector;
use Rector\EarlyReturn\Rector\Return_\ReturnBinaryOrToEarlyReturnRector; use Rector\EarlyReturn\Rector\Return_\ReturnBinaryOrToEarlyReturnRector;
use Rector\EarlyReturn\Rector\StmtsAwareInterface\ReturnEarlyIfVariableRector; use Rector\EarlyReturn\Rector\StmtsAwareInterface\ReturnEarlyIfVariableRector;
use Rector\Php80\Rector\ClassConstFetch\ClassOnThisVariableObjectRector; use Rector\Php80\Rector\ClassConstFetch\ClassOnThisVariableObjectRector;
use Rector\Set\ValueObject\LevelSetList;
use Rector\TypeDeclaration\Rector\ArrowFunction\AddArrowFunctionReturnTypeRector; use Rector\TypeDeclaration\Rector\ArrowFunction\AddArrowFunctionReturnTypeRector;
use Rector\TypeDeclaration\Rector\ClassMethod\AddMethodCallBasedStrictParamTypeRector; use Rector\TypeDeclaration\Rector\ClassMethod\AddMethodCallBasedStrictParamTypeRector;
use Rector\TypeDeclaration\Rector\ClassMethod\AddParamTypeFromPropertyTypeRector; use Rector\TypeDeclaration\Rector\ClassMethod\AddParamTypeFromPropertyTypeRector;
@ -35,54 +31,50 @@ use Rector\TypeDeclaration\Rector\ClassMethod\ParamTypeByMethodCallTypeRector;
use Rector\TypeDeclaration\Rector\ClassMethod\ParamTypeByParentCallTypeRector; use Rector\TypeDeclaration\Rector\ClassMethod\ParamTypeByParentCallTypeRector;
use Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromReturnDirectArrayRector; use Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromReturnDirectArrayRector;
use Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromReturnNewRector; use Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromReturnNewRector;
use Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictBoolReturnExprRector;
use Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictConstantReturnRector; use Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictConstantReturnRector;
use Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictNativeCallRector; use Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictNativeCallRector;
use Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictNewArrayRector; use Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictNewArrayRector;
use Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictTypedCallRector; use Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictTypedCallRector;
use Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictTypedPropertyRector; use Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictTypedPropertyRector;
use Rector\TypeDeclaration\Rector\Closure\AddClosureReturnTypeRector;
use Rector\TypeDeclaration\Rector\FunctionLike\AddParamTypeSplFixedArrayRector; use Rector\TypeDeclaration\Rector\FunctionLike\AddParamTypeSplFixedArrayRector;
use Rector\TypeDeclaration\Rector\FunctionLike\AddReturnTypeDeclarationFromYieldsRector; use Rector\TypeDeclaration\Rector\FunctionLike\AddReturnTypeDeclarationFromYieldsRector;
use Rector\TypeDeclaration\Rector\Param\ParamTypeFromStrictTypedPropertyRector;
use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromStrictConstructorRector; use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromStrictConstructorRector;
use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromStrictGetterMethodReturnTypeRector;
return static function (RectorConfig $c): void { return RectorConfig::configure()
$c->sets([LevelSetList::UP_TO_PHP_82]); ->withPhpSets(php83: true)
$c->rules([ ->withPreparedSets(
deadCode: true,
codeQuality: true,
typeDeclarations: true,
earlyReturn: true,
strictBooleans: true,
)
->withRules([
AddArrowFunctionReturnTypeRector::class, AddArrowFunctionReturnTypeRector::class,
AddClosureReturnTypeRector::class,
AddMethodCallBasedStrictParamTypeRector::class, AddMethodCallBasedStrictParamTypeRector::class,
AddParamTypeFromPropertyTypeRector::class, AddParamTypeFromPropertyTypeRector::class,
AddParamTypeSplFixedArrayRector::class, AddParamTypeSplFixedArrayRector::class,
AddReturnTypeDeclarationBasedOnParentClassMethodRector::class, AddReturnTypeDeclarationBasedOnParentClassMethodRector::class,
AddReturnTypeDeclarationFromYieldsRector::class, AddReturnTypeDeclarationFromYieldsRector::class,
BooleanNotIdenticalToNotIdenticalRector::class, BooleanNotIdenticalToNotIdenticalRector::class,
ChangeAndIfToEarlyReturnRector::class,
ChangeNestedForeachIfsToEarlyContinueRector::class, ChangeNestedForeachIfsToEarlyContinueRector::class,
ChangeNestedIfsToEarlyReturnRector::class, ChangeNestedIfsToEarlyReturnRector::class,
ChangeOrIfContinueToMultiContinueRector::class, ChangeOrIfContinueToMultiContinueRector::class,
ChangeOrIfReturnToEarlyReturnRector::class,
ClassOnThisVariableObjectRector::class, ClassOnThisVariableObjectRector::class,
CountArrayToEmptyArrayComparisonRector::class, CountArrayToEmptyArrayComparisonRector::class,
ExplicitBoolCompareRector::class, ExplicitBoolCompareRector::class,
InlineArrayReturnAssignRector::class, InlineArrayReturnAssignRector::class,
InlineIsAInstanceOfRector::class, InlineIsAInstanceOfRector::class,
NewlineAfterStatementRector::class,
NewlineBeforeNewAssignSetRector::class, NewlineBeforeNewAssignSetRector::class,
NullableCompareToNullRector::class, NullableCompareToNullRector::class,
ParamTypeByMethodCallTypeRector::class, ParamTypeByMethodCallTypeRector::class,
ParamTypeByParentCallTypeRector::class, ParamTypeByParentCallTypeRector::class,
ParamTypeFromStrictTypedPropertyRector::class,
PreparedValueToEarlyReturnRector::class, PreparedValueToEarlyReturnRector::class,
ReplaceMultipleBooleanNotRector::class, ReplaceMultipleBooleanNotRector::class,
ReturnBinaryAndToEarlyReturnRector::class,
ReturnBinaryOrToEarlyReturnRector::class, ReturnBinaryOrToEarlyReturnRector::class,
ReturnEarlyIfVariableRector::class, ReturnEarlyIfVariableRector::class,
ReturnTypeFromReturnDirectArrayRector::class, ReturnTypeFromReturnDirectArrayRector::class,
ReturnTypeFromReturnNewRector::class, ReturnTypeFromReturnNewRector::class,
ReturnTypeFromStrictBoolReturnExprRector::class,
ReturnTypeFromStrictConstantReturnRector::class, ReturnTypeFromStrictConstantReturnRector::class,
ReturnTypeFromStrictNativeCallRector::class, ReturnTypeFromStrictNativeCallRector::class,
ReturnTypeFromStrictNewArrayRector::class, ReturnTypeFromStrictNewArrayRector::class,
@ -95,6 +87,6 @@ return static function (RectorConfig $c): void {
StaticClosureRector::class, StaticClosureRector::class,
ThrowWithPreviousExceptionRector::class, ThrowWithPreviousExceptionRector::class,
TypedPropertyFromStrictConstructorRector::class, TypedPropertyFromStrictConstructorRector::class,
TypedPropertyFromStrictGetterMethodReturnTypeRector::class, RemoveAlwaysElseRector::class,
]); ])
}; ;

14
ecs.php
View file

@ -3,13 +3,11 @@
use Lubiana\CodeQuality\LubiSetList; use Lubiana\CodeQuality\LubiSetList;
use Symplify\EasyCodingStandard\Config\ECSConfig; use Symplify\EasyCodingStandard\Config\ECSConfig;
return static function (ECSConfig $c): void { return ECSConfig::configure()
$c->paths([ ->withSets([LubiSetList::ECS])
->withPaths(
[
__DIR__ . '/src', __DIR__ . '/src',
__DIR__ . '/config', __DIR__ . '/config',
__DIR__ . '/rector.php', ]
__DIR__ . '/ecs.php', )->withRootFiles();
]);
$c->sets([LubiSetList::ECS]);
};

View file

@ -3,13 +3,11 @@
use Lubiana\CodeQuality\LubiSetList; use Lubiana\CodeQuality\LubiSetList;
use Rector\Config\RectorConfig; use Rector\Config\RectorConfig;
return static function (RectorConfig $c): void { return RectorConfig::configure()
$c->paths([ ->withPaths([
__DIR__ . '/src', __DIR__ . '/src',
__DIR__ . '/config', __DIR__ . '/config',
__DIR__ . '/rector.php', ])
__DIR__ . '/ecs.php', ->withSets([LubiSetList::RECTOR])
]); ->withRootFiles()
;
$c->sets([LubiSetList::RECTOR]);
};

View file

@ -4,7 +4,6 @@ namespace Lubiana\CodeQuality;
final class LubiSetList final class LubiSetList
{ {
public const RECTOR = __DIR__ . '/../config/rector.php'; public const string RECTOR = __DIR__ . '/../config/rector.php';
public const string ECS = __DIR__ . '/../config/ecs.php';
public const ECS = __DIR__ . '/../config/ecs.php';
} }

View file

@ -1,17 +0,0 @@
<?php declare(strict_types=1);
namespace Lubiana\CodeQuality;
/** @deprecated use LubiSetList */
final class SetList
{
/**
* @deprecated use LubiSetList::RECTOR
*/
public const RECTOR = LubiSetList::RECTOR;
/**
* @deprecated use LubiSetList::ECS
*/
public const ECS = LubiSetList::ECS;
}