some more typo and readability fixes

This commit is contained in:
lubiana 2022-04-30 21:24:25 +02:00 committed by Andre Lubian
parent 68d4abab8f
commit e4fa8b8e42
3 changed files with 11 additions and 12 deletions

View file

@ -58,7 +58,7 @@ $environment = getenv('ENVIRONMENT') ?: 'dev';
error_reporting(E_ALL); error_reporting(E_ALL);
$whoops = new Run; $whoops = new Run;
if ($environment == 'dev') { if ($environment === 'dev') {
$whoops->pushHandler(new PrettyPageHandler); $whoops->pushHandler(new PrettyPageHandler);
} else { } else {
$whoops->pushHandler(function (\Throwable $e) { $whoops->pushHandler(function (\Throwable $e) {

View file

@ -47,7 +47,7 @@ Line Bootstrap.php
The second error is something that "declare strict-types" already catches for us, but the first error is something that The second error is something that "declare strict-types" already catches for us, but the first error is something that
we usually would not discover easily without speccially looking for this errortype. we usually would not discover easily without speccially looking for this errortype.
We can add a simple configfile called phpstan.neon to our project so that we do not have to specify the errorlevel and We can add a simple configfile called `phpstan.neon` to our project so that we do not have to specify the errorlevel and
path everytime we want to check our code for errors: path everytime we want to check our code for errors:
```yaml ```yaml
@ -90,16 +90,15 @@ on an old legacy codebase and wanted to add static analysis to it but cant becau
everytime we use phpstan, we could add all those errors to a list and tell phpstan to only bother us about new errors we everytime we use phpstan, we could add all those errors to a list and tell phpstan to only bother us about new errors we
are adding to our code. are adding to our code.
In order to use that we have to add an empty file 'phpstan-baseline.neon' to our project, include that in the In order to use that we have to add an empty file `phpstan-baseline.neon` to our project, include that in the
phpstan.neon file and run phpstan with the `phpstan.neon` file and run phpstan with the `--generate-baseline` option:
'--generate-baseline' option:
```yaml ```yaml
includes: includes:
- phpstan-baseline.neon - phpstan-baseline.neon
parameters: parameters:
level: 9 level: max
paths: paths:
- src - src
``` ```
@ -127,7 +126,7 @@ directory.
You can read more about its usage and possible rulesets in the [documentation](https://github.com/FriendsOfPHP/PHP-CS-Fixer#documentation) You can read more about its usage and possible rulesets in the [documentation](https://github.com/FriendsOfPHP/PHP-CS-Fixer#documentation)
personally i like to have a more opiniated version with some rules added to the psr-12 standard and have therefore setup personally i like to have a more opiniated version with some rules added to the psr-12 standard and have therefore setup
a configuration file that i use in all my projects .php-cs-fixer.php: a configuration file that i use in all my projects `.php-cs-fixer.php`:
```php ```php
<?php declare(strict_types=1); <?php declare(strict_types=1);
@ -174,7 +173,7 @@ return $config
The PHPCodesniffer is sort of a combination of the previous tools, it checks for a defined codingstyle and some extra The PHPCodesniffer is sort of a combination of the previous tools, it checks for a defined codingstyle and some extra
rules that are not just stylechanges but instead enforces extra rules in if-statements, exception handling etc. rules that are not just stylechanges but instead enforces extra rules in if-statements, exception handling etc.
it provides the phpcs command to check for violations and the phpcbf command to actually fix most of the violations. it provides the `phpcs` command to check for violations and the `phpcbf` command to actually fix most of the violations.
Without configuration the tool tries to apply the PSR12 standard just like the php-cs-fixer, but as you might have Without configuration the tool tries to apply the PSR12 standard just like the php-cs-fixer, but as you might have
guessed we are adding some extra rules. guessed we are adding some extra rules.
@ -184,7 +183,7 @@ Lets install the ruleset with composer
composer require --dev mnapoli/hard-mode composer require --dev mnapoli/hard-mode
``` ```
and add a configuration file to actually use it '.phpcs.xml.dist' and add a configuration file to actually use it `.phpcs.xml.dist`
```xml ```xml
<?xml version="1.0"?> <?xml version="1.0"?>
<ruleset> <ruleset>
@ -233,8 +232,8 @@ you could just write dd($whoops) somewhere in your bootstrap.php to check how th
#### Composer scripts #### Composer scripts
now we have a few commands that are available on the command line. i personally do not like to type complex commands now we have a few commands that are available on the command line. I personally do not like to type complex commands
with lots of parameters by hand all the time, so i added a few lines to my composer.json: with lots of parameters by hand all the time, so I added a few lines to my `composer.json`:
```json ```json
"scripts": { "scripts": {

View file

@ -86,7 +86,7 @@ return function(\FastRoute\RouteCollector $r) {
}; };
``` ```
Now let's rewrite the route dispatcher part to use the `Routes.php` file. Now let's rewrite the route dispatcher part to use the `routes.php` file.
```php ```php
$routeDefinitionCallback = require __DIR__ . '/../config/routes.php'; $routeDefinitionCallback = require __DIR__ . '/../config/routes.php';